Skip to content

🎨 e2e Metamodeling: Improve project creation #8477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 8, 2025
Merged

🎨 e2e Metamodeling: Improve project creation #8477

merged 11 commits into from
Oct 8, 2025

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 8, 2025 •
edited
Loading

What do these changes do?

This PR enhances the e2e MMUX testing by improving HTTP response handling and adding structured logging. The changes focus on making the pipeline creation more robust with proper response validation and clearer debugging output.

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz marked this pull request as draft October 8, 2025 09:28
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (546db3a) to head (dc8a273).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8477      +/-   ##
==========================================
- Coverage   87.63%   87.56%   -0.07%     
==========================================
  Files        1995     1992       -3     
  Lines       77564    77345     -219     
  Branches     1333     1333              
==========================================
- Hits        67973    67730     -243     
- Misses       9192     9216      +24     
  Partials      399      399
Flag Coverage Δ *Carryforward flag
integrationtests 64.09% <ø> (+0.05%) ⬆️
unittests 86.31% <ø> (-0.02%) ⬇️ Carriedforward from c7bdff6

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 83.24% <ø> (-1.04%) ⬇️
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library 93.07% <ø> (ø)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database 87.95% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.93% <ø> (+<0.01%) ⬆️
pkg_settings_library 90.19% <ø> (ø)
pkg_simcore_sdk 84.89% <ø> (-0.06%) ⬇️
agent 93.54% <ø> (ø)
api_server 91.90% <ø> (-0.01%) ⬇️
autoscaling 95.71% <ø> (ø)
catalog 92.36% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.78% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 75.90% <ø> (+0.08%) ⬆️
director_v2 91.04% <ø> (+0.08%) ⬆️
dynamic_scheduler 96.60% <ø> (-0.25%) ⬇️
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.74% <ø> (ø)
invitations 91.41% <ø> (ø)
payments 92.71% <ø> (ø)
resource_usage_tracker 92.15% <ø> (-0.06%) ⬇️
storage 86.74% <ø> (+0.28%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.15% <ø> (-0.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 546db3a...dc8a273. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz self-assigned this Oct 8, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Oct 8, 2025
@odeimaiz odeimaiz marked this pull request as ready for review October 8, 2025 09:46
@odeimaiz odeimaiz requested a review from Copilot October 8, 2025 09:46
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Oct 8, 2025
Copilot AI reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the end-to-end testing for response surface modeling by improving HTTP response handling and adding structured logging. The changes focus on making the test more robust with proper response validation and clearer debugging output.

  • Refactored HTTP response expectations with proper status code assertions
  • Added structured logging with context blocks for better test debugging
  • Improved code organization by extracting the project UUID into a variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

wvangeit
wvangeit approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odeimaiz

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for dc8a273.

🟢 All jobs passed!

But CI Insights is watching 👀

matusdrobuliak66
matusdrobuliak66 approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) October 8, 2025 11:33
@odeimaiz odeimaiz changed the title 🎨 e2e: Metamodeling 🎨 e2e Metamodeling: Improve project creation Oct 8, 2025
@odeimaiz odeimaiz disabled auto-merge October 8, 2025 11:33
@odeimaiz odeimaiz enabled auto-merge (squash) October 8, 2025 11:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@odeimaiz odeimaiz merged commit f6bfc51 into ITISFoundation:master Oct 8, 2025
94 of 95 checks passed
This was referenced Oct 28, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@wvangeit wvangeit wvangeit approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@alexpargon alexpargon Awaiting requested review from alexpargon

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@odeimaiz odeimaiz

Labels

e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

3 participants

@odeimaiz @wvangeit @matusdrobuliak66